Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

Took another pass at this and it won't quite line up with what's in sundrio. The initial commit is referencing io.sundr.builder.Editable, and generates / builds just fine. However our generated sundrio logic will actually reference io.fabric8.kubernetes.api.builder.Editable. If I try to reference io.fabric8.kubernetes.api.builder.Editable in the jsonschema2pojo that results in an NPE.

One option is to leave this decoupled from sundrio and not implement the interface. Users would still do:

pod.toBuilder().... rather than new PodBuilder(pod)...

but the dependent builder logic would not find these methods and would still use reflection if needed.

Another option is to somehow move the io.fabric8.kubernetes.api.builder classes into kubernetes-model-common.

Another option is to somehow move the io.fabric8.kubernetes.api.builder classes into kubernetes-model-common.

Updated the pr with what that would look like. A dummy class is used to trigger the builder package inclusion in the common module - the class and generated output are removed from the jar.

What's not shown is that the core model needs regenerated to flip the generateBuilderPackage value to false.

In total we're marking the class as Editable and adding an edit method with an alias of toBuilder. Obviously the toBuilder method could be handled upstream as a default on the interface.

@manusa @iocanel @rohanKanojia @metacosm does this messiness seem worth it?

I'll see if I can resolve then NPE this upstream in sundrio before moving forward with this hack based approach.

I'll see if I can resolve then NPE this upstream in sundrio before moving forward with this hack based approach.

Opened sundrio/sundrio#396 but could not see how to immediately resolve it. We'll probably need to use this workaround if we want to make the pojos editable any time soon.

Some thoughts:

On BaseFluent.builderOf

AFAIR this uses Class.forName and its something I would really like to avoid. Ideally, this should move down one level into the concrete fluent (where it can be re-implemented without reflection).

kubernetes model builder package

One way of solving the chicken and egg thing with jsonschema2pojo would be to generate the package in separate jar, that jsonschema2pojo can depend on. The rest of the model can depend on that jar and not regenerate the model.

A completely different approach would be to add the method using a lombok style byte code manipulation (however this would have to be done on sundrio).

edit() vs toBuilder()

It doesn't really matter which one will be used, but ...
It would be really nice if whatever method is used is expressed using an interface. It would make things easier when parsing files, and apply visitors etc.

AFAIR this uses Class.forName and its something I would really like to avoid. Ideally, this should move down one level into the concrete fluent (where it can be re-implemented without reflection).

The first check in builderOf is for if the item is Editable.

One way of solving the chicken and egg thing with jsonschema2pojo would be to generate the package in separate jar, that jsonschema2pojo can depend on. The rest of the model can depend on that jar and not regenerate the model.

That is in this pr - a dummy class is used to trigger the creation of the fabric8 builder package in a different class.

It would be really nice if whatever method is used is expressed using an interface. It would make things easier when parsing files, and apply visitors etc.

If you are open to it upstream, then toBuilder could be added as a default method.

From a end user perspective it's still a little awkward as an interface (we talked about this a little on a sundrio issue) - as there's currently no additional bounds, you'll need to at least cast to VisitableBuilder.

@metacosm @manusa marking this as ready. A follow-up will be to add the toBuilder method to the Editable interface.

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Catch issues before they fail your Quality Gate with our IDE extension SonarLint